Conversation
|
@blueorangutan docbuild |
|
@sureshanaparti a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/504. (QA-JID 339) |
|
@rajujith Update the usage types (still the record formats for these to be updated) |
|
@blueorangutan docbuild |
|
@sureshanaparti a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/504. (QA-JID 342) |
|
quite frankly I am against this change. there is a list usage types API and it should document the usage types. adding/updating the docs on this in creating a split source of truth. |
@DaanHoogland, The doc in its current form has already diverged from the source of truth, so adding the missing usage types wouldn’t introduce any additional inconsistency. As a potential improvement, perhaps we could sync the doc with the missing Usage Types and clearly mention that users should refer to the list Usage Types API for the most up-to-date information? I was hoping to add some details related to Backup usage to the doc, but currently, Backup isn’t even mentioned as a usage type. |
|
@abh1sar ,
I do not believe that is a reason to let it like this. I think the paragraph should be removed and replaced with a link/command to retrieve the data from the API. We are creating a path to continuous maintenance and probably technical debt if we allow for documentation of things which are also documented in code.
If this is implemented in an update script we still need to have it run and humans will forget.
That should be solved in the source (i.e. the API doc, not in this file) |
|
@sureshanaparti @rajujith @weizhouapache , I do not like this way maintaining this information but am not going to reject it. Should we merge this? |
@DaanHoogland |
In my opinion we should return the description in the table with the |
There was a problem hiding this comment.
Pull request overview
This PR updates the usage types documentation to sync it with the current CloudStack API response and codebase. The documentation was outdated, referencing "Cloud.com" instead of "CloudStack" and missing several usage types (IDs 21-31).
Changes:
- Updated "Cloud.com" references to "CloudStack" in usage type descriptions
- Corrected type 9 description from "Template" to "Snapshot"
- Added missing usage types 21-31 including VM disk I/O metrics, snapshots, backup, bucket, network, and VPC usage types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | | | from when a Template | | ||
| | | | from when a Snapshot | | ||
| | | | has been created to | | ||
| | | | the time it have been | |
There was a problem hiding this comment.
Grammar error: 'it have been' should be 'it has been' to maintain subject-verb agreement.
| | | | the time it have been | | |
| | | | the time it has been | |
| | 25 | VM\_SNAPSHOT | Tracks the total time a | | ||
| | | | VM Snapshot has been | | ||
| | | | created to the time when | | ||
| | | | it has been destroyed. | |
There was a problem hiding this comment.
Inconsistent phrasing: Type 25 uses 'total time a VM Snapshot has been created to the time when' while type 9 uses 'from when a Snapshot has been created to the time'. Consider using consistent phrasing across similar usage type descriptions for better readability.
| | 25 | VM\_SNAPSHOT | Tracks the total time a | | |
| | | | VM Snapshot has been | | |
| | | | created to the time when | | |
| | | | it has been destroyed. | | |
| | 25 | VM\_SNAPSHOT | Tracks the total time from | | |
| | | | when a VM Snapshot has | | |
| | | | been created to the time | | |
| | | | when it has been destroyed. | |
This PR updates/sync the usage types in docs with the API response and code.
Fixes apache/cloudstack#10813
Current doc: https://docs.cloudstack.apache.org/en/latest/adminguide/usage.html#usage-types.
list usagetypes API response =>
code =>
https://github.com/apache/cloudstack/blob/39c5641cbe674b19bc77082b850565f634a7cb84/api/src/main/java/org/apache/cloudstack/usage/UsageTypes.java#L24-L50
📚 Documentation preview 📚: https://cloudstack-documentation--504.org.readthedocs.build/en/504/